pelahi / VELOCIraptor-STF

Galaxy/(sub)Halo finder for N-body simulations
MIT License
19 stars 26 forks source link

Metadata output #49

Closed JBorrow closed 5 years ago

JBorrow commented 5 years ago

Currently, velociraptor writes a number of text files containing metadata. It would be really helpful if the contents of these files (.siminfo in particular) were added to the HDF5 .properties output.

Alongside this, it would be incredibly useful to have the boxsize added as an attribute in the .properties output.

pelahi commented 5 years ago

Currently the properties file does have the box size, scale factor and unit conversions in the attributes. However, I could add a more complete list, including full cosmology, simulation info, units as separate groups in the HDF5 output along with the configuration options. I will try to implement this soon.

JBorrow commented 5 years ago

Was this box-size added recently? I can't seem to find it in any of my properties catalogues. I only have the following properties:

halo_008_z005p920.properties
├10 attributes:
│ ├Comoving_or_Physical: 0
│ ├Cosmological_Sim: 1
│ ├Length_unit_to_kpc: 1000.0
│ ├Mass_unit_to_solarmass: 10000000000.0
│ ├Metallicity_unit_to_solar: 1.0
│ ├Period: 3.6127167630057806
│ ├SFR_unit_to_solarmassperyear: 1.0
│ ├Stellar_age_unit_to_yr: 1.0
│ ├Time: 0.14450867052023122
│ └Velocity_to_kms: 1.0

More attributes would certainly be helpful. If possible, it would be nice to have them organised as follows:

/Cosmology
 - Comoving_or_Physical
 - Cosmological_Sim
 - Scale_Factor
 - Redshift
 - Time (Actual time in Gyr)
/Units
 - Whatever units you think are relevant
/Code
 - Information on the code that generated the snapshots
 - Information on the version of velociraptor we are using e.g. configuration options.
JBorrow commented 5 years ago

Something else here is that the units aren't particularly consistent. For instance, stellar ages are given in one unit, which is inconsistent with the time specified by the length and velocity unit. Star formation rate is again inconsistent with the mass and time units... Perhaps this is desirable as it makes the catalogues more human-readable but it can be confusing which unit actually applies for some properties.

pelahi commented 5 years ago

I'll add the extra meta information but I think I will leave the units as is, as they are more human-readable. However, I could provide a second set that is fixed to make all the units consistent (conversion to cgs say). As for the box size, this is given by 'Period'.

JBorrow commented 5 years ago

Ah ok! In that case, I think there is some h-factor stuff going on there. This is a 25 Mpc SWIFT run, and it's saying that the boxsize is 36 Mpc, which is ~ 25 / 0.7 Mpc.

pelahi commented 5 years ago

The period is for that time and is in physical units. Period = 25 Mpc a = 25 0.14 = 3.6. Also, I've just pushed a new branch with more meta information written to the properties file. I haven't tested it yet and will add more info but if you don't mind, have a go

pelahi commented 5 years ago

Meta branch merged into master