jesmigel
commented
4 years ago Merging from development to feature/encapsulation
Closed jesmigel closed 4 years ago
jesmigel
commented
4 years ago Merging from development to feature/encapsulation
Generalising HDF5 write to allow for C or C++ API
Updating HDF code to change to C API
More updates to move to C HDF API
Updates to HDF5 interface
Update to HDF5 interface
Update to HDF interface
New HDF5 Interface in place
The new HDF5 interface using only C API is now compiling. Needs testing.
New HDF5 interface in place, linking errors fixed.
Added debugging info to determine why HDF interace not working
More Debugging of C HDF, hyperslab selection issue.
Update to C HDF, hyperslab functioning
MPI HDF5 box size misread bug fix.
Code clean-up
Removal of commented code
Update to cmake language check
Minor Bug fixes
Bug fix to non-MPI HDF5 and when reading hydro data.
Remove of last bit of C++ HDF5
Bug fix for mpi hdf read
Bug fix for mpi hdf read
Update to c hdf5 to handle strings, bug fix in profile output
Bug fix to rotational gas properties calculated
Update to information written about configuration options used.
Update to modes of operation for local velocity calculation
Update to meta information produced
Now info contains type information in the simulation info, unit info, and configuration info files.
Update to local field for baryons
Improved mpi memory footprint
Update to code to minimise memory footprint when searching particles on other mpi domains for local velocity calculations and SO mass estimates. Also better handling of baryons (whether to use them in measuring local velocity densities).
Removed unnecessary auto
Update to configuration file produced by VR
Configuration file contains data type information and also some compile time options.
Update of version number
Bug fix to reading swift hydro HDF5
Bug fix to catalog_groups hdf file
Incorrectly overwriting information.
Bug fix to HDF5
Updates to handle SWIFT HDF5 input
Bug fix.
Incorrect variable name when compiled with STARON
Feature/encapsulation (#50)
Replaced loop line num with encapsulation ID
COMMENTS: Parametisation
COMMENTS: returned initial //ADACS
COMMENT: added end to ENCAPSULATION-01
Updated comment tags
TEST ENCAPSULATION: ENCAPSULATE-01
Encapsulation failed. Reverted back to old variable assignment logic but printing out values yielded by the new function
Added cout against cmx variable
TEST: encapsulation
ENCAPSULATION-01: function implementation
ENCAPSULATION-01: encapsulation N/A due to pragma directive
Segmentation fault during runtime
ENCAPSULATION-01: used pointer to array for segfault
ENCAPSULATION-01: Segfault fix by static variables
Python script to compare catalogs
Added a script that compares two VR catalogs. The idea is to compare a reference output to a comparison one produced with a newer version of VR. Useful for testing changes.
I have suggested an encapsulation, making use of existing functions. Will need alterations to make use of a maximum thread pool.
Returned original code in preparation for encapsulating entire ENCAPSULATE-01 block
Syntax error. Added closing )
Removed proof of concept encapsulation
Deleted unused test array
Bug fix, missing readline call.
Bug fix in python comparison script
bug fix
added script to profile VR
bug fix in script.
Quick update to encapsulation
Rollback to baseline code
Bug fix and code format update in encapsulation region.
Commented suggested block
ENCAPSULATE-01: Remiplemented PJE suggestion and updated statemets using cmvel by accessing contents of returned cm by CalcPhaseCM
Print variables to be compared
Reverted back to baseline seach but included suggested encapsulation function
suggested encapsulation by PJE
Added print statements for comparison
updated comparison variables
Added print statement for unique particle ids present in reference result missing from output being compared to
Marked block for particle id comparison
Successful encapsulation comparison. Removed commented block
ENCAPSULATION: PreCalcSearchSubSet
Final encapsulation
Added stdout thread count
newline to threadcount
OPTIMISATION-01: Print statements
Reverted to settyp(0)