search

pelargir / auto-session-timeout

Provides automatic session timeout in a Rails application.
MIT License
126 stars 63 forks source link

Add vanilla js PeriodicalQuery fallback #18

Closed emilos closed 7 years ago

emilos commented 7 years ago

Hey :)

thanks for the lib :+1: . I've added a fallback so that it works in envs where there's no $ plus added a possibility to add additional attributes to the script tag. This should help with https://github.com/pelargir/auto-session-timeout/issues/16

pelargir commented 7 years ago

This looks good. I'm actually thinking we should just use the vanilla implementation and remove the library-specific code completely. I can't think of a reason to keep the library-specific code around if the vanilla implementation works. Would you mind updating the PR to do that?

emilos commented 7 years ago

@pelargir no worries :) I'll take care of this later today

emilos commented 7 years ago

@pelargir done, please have a look again

pelargir commented 7 years ago

Very nice. Merging.