pele-python / mcpele

Monte Carlo and parallel tempering routines built on the pele foundation
Other
20 stars 5 forks source link

increase tolerance metropolis test #25

Closed kjs73 closed 10 years ago

kjs73 commented 10 years ago

Sometimes this test fails due to fluctuations (different seeds). The tolerance on the heat capacity is increased to make that less likely. Alternatively one could also fix the rng seed.

smcantab commented 10 years ago

let's fix the seed, it's much easier to detect problems that way

On Mon, Jul 14, 2014 at 3:14 PM, kjs73 notifications@github.com wrote:

Sometimes this test fails due to fluctuations (different seeds). The tolerance on the heat capacity is increased to make that less likely.

Alternatively one could also fix the rng seed.

You can merge this Pull Request by running

git pull https://github.com/kjs73/mcpele test_fluctuation

Or view, comment on, or merge it at:

https://github.com/pele-python/mcpele/pull/25 Commit Summary

  • increase tolerance

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/pele-python/mcpele/pull/25.

kjs73 commented 10 years ago

OK I agree that fixing the seed is better.

js850 commented 10 years ago

Please also fix the seed.