Time series moving average - Githubissues

pele-python / mcpele

Monte Carlo and parallel tempering routines built on the pele foundation

Other

20 stars 5 forks source link

Time series moving average #36

Closed kjs73 closed 9 years ago

kjs73 commented 10 years ago

Add simple moving average test to check if time series is drifting.

There are more sophisticated tests for time series behaviour, but they are quite complicated and possibly overkill here.

Actually I am not sure if the wrapping of the boolean return value is handled correctly in line 236 of file _action_cpp.pyx. Do you guys have an expert opinion on that?

js850 commented 10 years ago

there is never any need to do

if is_stable == True:

This is exactly equivalent to the much more succinct

if is_stable:

the same holds for returning a bool

PEP8:

Don't compare boolean values to True or False using ==.

kjs73 commented 10 years ago

Thank you! It should be fixed now.

coveralls commented 10 years ago

Changes Unknown when pulling 231b48caa11f8ed1c42f60410dbe588b9f76748a on kjs73:time_series_moving_average into \ on pele-python:master**.

coveralls commented 10 years ago

Coverage remained the same when pulling d75609e7679343d2d784742b5939b3518d59aa33 on kjs73:time_series_moving_average into 024508bb6eec32501f5c445d807bd46a3605d1f6 on pele-python:master.

coveralls commented 9 years ago

Coverage remained the same when pulling 08b16dc1943f3d44d2e68615d9a53a1e0e218ea7 on kjs73:time_series_moving_average into 024508bb6eec32501f5c445d807bd46a3605d1f6 on pele-python:master.

coveralls commented 9 years ago

Coverage decreased (-0.12%) when pulling e8b7d1efc34ed01766ff3bc1ed68c07f165c48b1 on kjs73:time_series_moving_average into 024508bb6eec32501f5c445d807bd46a3605d1f6 on pele-python:master.

coveralls commented 9 years ago

Coverage decreased (-0.73%) when pulling 983cf50779b6178751d16690aa2b60022a176ab4 on kjs73:time_series_moving_average into 024508bb6eec32501f5c445d807bd46a3605d1f6 on pele-python:master.

coveralls commented 9 years ago

Coverage decreased (-1.42%) when pulling 58e3418362b4df0b5b63a7ac4c50f523a96150ad on kjs73:time_series_moving_average into 024508bb6eec32501f5c445d807bd46a3605d1f6 on pele-python:master.

coveralls commented 9 years ago

Coverage decreased (-1.44%) when pulling 91b0e940b5ce054b01d747117b8f3d8361c450d3 on kjs73:time_series_moving_average into 5fb017918a416e37921448b114021b439ba3f56a on pele-python:master.

js850 commented 9 years ago

I think this looks good

coveralls commented 9 years ago

Coverage decreased (-1.44%) when pulling b15bc7fc7ba757d9cb2a61bdaf3ef0bad2e2ac28 on kjs73:time_series_moving_average into e2811e487154d096794b6cdc5e908b43eb8b0371 on pele-python:master.

coveralls commented 9 years ago

Coverage decreased (-1.56%) when pulling 66ce41d628676eed5aaa8b14a7ce6172f1d9277d on kjs73:time_series_moving_average into e2811e487154d096794b6cdc5e908b43eb8b0371 on pele-python:master.