search

pele-python / mcpele

Monte Carlo and parallel tempering routines built on the pele foundation
Other
20 stars 5 forks source link

the single python test segfaults #5

Closed js850 closed 10 years ago

js850 commented 10 years ago

TestMetropolis.test_heat_capacity segfaults

We need some working tests as a first priority. It's hard to improve anything unless you have tests to run.

smcantab commented 10 years ago

the test passes on my computer, the segfault might be due to the fact that I have not pushed my latest changes to pele? try change pele to the branch new_fire and see whether it passes then. I'm gonna sort out that pr now

kjs73 commented 10 years ago

That is, before the merge of the pull request.

On 3 July 2014 10:58, Julian Schrenk kjs73@cam.ac.uk wrote:

On my desktop that test also worked yesterday.

On 3 July 2014 10:56, smcantab notifications@github.com wrote:

the test passes on my computer, the segfault might be due to the fact that I have not pushed my latest changes to pele? try change pele to the branch new_fire and see whether it passes then. I'm gonna sort out that pr now

— Reply to this email directly or view it on GitHub https://github.com/pele-python/mcpele/issues/5#issuecomment-47887658.

kjs73 commented 10 years ago

Sorry, messe up the comments. I just meant to say that this particular test worked on my desktop as well.

js850 commented 10 years ago

If i use stefano's branch new_fire it passes for me as well. What is the change that fixed it?