pele-python / pele

Python energy landscape explorer
Other
95 stars 41 forks source link

hungarian package installation #167

Open woodg07 opened 5 years ago

woodg07 commented 5 years ago

I'm getting an error on install the hungarian package using python 3.6:

-bash-4.2$ pip install hungarian Collecting hungarian Downloading https://files.pythonhosted.org/packages/b2/f9/9cccbbb8c724c4eff5d006bd3fe185e91d121caf2ffd345fe31421f1c886/hungarian-0.2.3.tar.gz Building wheels for collected packages: hungarian Running setup.py bdist_wheel for hungarian ... error Complete output from command /nfs/grid/software/pharmsci/apps/Linux-x86_64-RHEL7/anaconda3/envs/my-rdkit-env/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-2diisrml/hungarian/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" bdist_wheel -d /tmp/pip-wheel-ue8vcxk1 --python-tag cp36: running bdist_wheel running build running config_cc unifing config_cc, config, build_clib, build_ext, build commands --compiler options running config_fc unifing config_fc, config, build_clib, build_ext, build commands --fcompiler options running build_src build_src building extension "hungarian" sources

js850 commented 5 years ago

Not too sure, but it looks like the hungarian c++ code uses a deprecated numpy api. It's probably incompatible with the version of numpy you're using.

Hungarian is not necessary for pele. It's functionality is duplicated by the minpermdist function. The minpermdist is faster, so that is set as the default. See mindist/permutational_alignment.py.

I suggest just skipping the hungarian install.

arianvc commented 5 years ago

I had the same problem. I tried to install the hungarian package separately and it worked. Download it from: https://github.com/hrldcpr/hungarian Then use a formatter like clang-format to fix the formatting issues in asp.cpp file: clang-format -i asp.cpp Then follow the instructions on the same github repo (python setup.py build etc.)

js850 commented 5 years ago

Thanks @arianvc . If you're feeling keen you might consider submitting a pull request to fix the hungarian package. I submitted a fix a few years ago and the author seemed happy to receive the change.