glog doesn't build against gflags 2.1

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Install gflags 2.1
2. Compile glog from fresh checkout

What is the expected output? What do you see instead?

Errors:

In file included from /usr/local/include/gflags/gflags.h:84:0,
                 from src/glog/logging.h:85,
                 from src/utilities.h:82,
                 from src/logging.cc:32:
/usr/local/include/gflags/gflags_declare.h:45:8: error: operator '&&' has no 
left operand
In file included from src/utilities.h:82:0,
                 from src/logging.cc:32:
src/glog/logging.h:330:1: error: 'GFLAGS_NAMESPACE' does not name a type
src/glog/logging.h:330:1: error: 'fLI::FLAGS_stderrthreshold' has not been 
declared
src/glog/logging.h:337:1: error: 'GFLAGS_NAMESPACE' does not name a type
src/glog/logging.h:337:1: error: 'fLI::FLAGS_logbuflevel' has not been declared
src/glog/logging.h:340:1: error: 'GFLAGS_NAMESPACE' does not name a type
src/glog/logging.h:340:1: error: 'fLI::FLAGS_logbufsecs' has not been declared
src/glog/logging.h:344:1: error: 'GFLAGS_NAMESPACE' does not name a type
src/glog/logging.h:344:1: error: 'fLI::FLAGS_minloglevel' has not been declared
src/glog/logging.h:354:1: error: 'GFLAGS_NAMESPACE' does not name a type
src/glog/logging.h:354:1: error: 'fLI::FLAGS_v' has not been declared
src/glog/logging.h:357:1: error: 'GFLAGS_NAMESPACE' does not name a type
src/glog/logging.h:357:1: error: 'fLI::FLAGS_max_log_size' has not been declared
src/logging.cc: In function 'bool google::SendEmailInternal(const char*, const 
char*, const char*, bool)':
src/logging.cc:1682:7: error: 'FLAGS_v' was not declared in this scope
make: *** [libglog_la-logging.lo] Error 1

Additional info:
gflags 2.1 was released recently -- March 20.
I'm able to compile just fine using gflags 2.0

Original issue reported on code.google.com by rsbo...@google.com on 27 Mar 2014 at 9:53

GoogleCodeExporter commented 9 years ago

Hadn't seen this issue when I searched and opened my own (195). 
In the recent gflags release, the (default) namespace is change from 'google' 
to 'gflags' and the GFLAGS_NAMESPACE variable is added for compatibility. It is 
not desirable to build the gflags library with a non-default value for 
GFLAGS_NAMESPACE because other projects may rely on it.

Original comment by jeff.veg...@gmail.com on 31 Mar 2014 at 11:53

GoogleCodeExporter commented 9 years ago

Here's a patch!

The namespace is hardcoded right now. If I should change that, let me know.

Original comment by dfu...@dattobackup.com on 24 Apr 2014 at 5:18

Attachments:

glog-0.3.3-gflags-namespace.patch

pelegm / google-glog

glog doesn't build against gflags 2.1 #194