search

pelias-deprecated / dockerfiles

Containerized Local Installation Package for the Pelias geocoder
https://pelias.io
MIT License
32 stars 25 forks source link

Enable the Libpostal Service #42

Closed orangejulius closed 6 years ago

orangejulius commented 6 years ago

As mentioned in https://github.com/pelias/api/pull/1060 and https://github.com/pelias/api/issues/1072, we have started converting Libpostal to its own service, rather than loading it into memory in the API service. This PR adds support for that in the dockerfiles.

It's ready to go immediately, although for now it will have to use an API docker image built off of the master branch.

I'd like to merge this before we merge the API changes for the libpostal service to the production branch, to ensure there's a seamless transition. Then we should go back and update the docker-compose.yml file to point to the production Docker images.

missinglink commented 6 years ago

I got stung with this today, seems the libpostal service code was already merged to master

missinglink commented 6 years ago

is it possible to change pelias/api:master to pelias/api and merge this @orangejulius?

missinglink commented 6 years ago

if the docker image is still not at latest (because the code hasn't made it to the release branch yet, then I'm cool to merge this as-is, with the tag master)

approving, will let you decide what's best

orangejulius commented 6 years ago

Okay, this has been open for a while, it's time to merge

orangejulius commented 6 years ago

We will be merging the libpostal-service change to pelias-api to production/latest soon!