Upgrade Helm charts for Kubernetes 1.16 compatibility.

pelias-deprecated / kubernetes

Tools for running Pelias services on kubernetes

MIT License

54 stars 47 forks source link

Upgrade Helm charts for Kubernetes 1.16 compatibility. #112

Closed williamflynt closed 4 years ago

williamflynt commented 4 years ago

:wave: I did some ~awesome~ minimal work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change :rocket:

Initial hack at #111

Here's what actually got changed :clap:

[x] Simple search and replace from extensions/v1beta1 --> apps/v1, plus a bonus search and replace from apps/v1beta1 --> apps/v1.
[x] Additionally, added spec.selector.matchLabels.app to deployment templates.

Here's how others can test the changes :eyes:

I tested very briefly via deployment to minikube:

minikube start
helm install --name pelias --namespace pelias ./ -f ./values.yaml

This results in a success message.

orangejulius commented 4 years ago

Hi @williamflynt, Thanks for this PR!

I've finally had time to test this PR and it looks good. I made some changes and pushed them to your branch so it can be merged:

I removed any changes to the experimental branch. We don't really used that stuff and haven't tested it, so it's not worth updating. If someone else wants to use it and can confirm changes are needed, I'd be happy to handle that in a separate PR
I removed the changes to add selectors to the deployments. I'm not sure if this is needed, but because of API canary deployment, which is tremendously useful, we'd have to test that very carefully. Let me know if you've found that those changes are required, and we can take care of it, but in a separate PR
Finally I removed the changes to update the apiVersion for Ingress objects, because it seems they aren't out of beta yet.

prashanth-nani commented 4 years ago

👋 Hi @orangejulius, As per the following quote from Kubernetes Deployment documentation

In API version apps/v1, .spec.selector and .metadata.labels do not default to .spec.template.metadata.labels if not set. So they must be set explicitly. Also note that .spec.selector is immutable after creation of the Deployment in apps/v1.

.spec.selector is mandatory in API version apps/v1. Since, apiVersion is updated to apps/v1 the deployments are no longer working when running helm install.

I have created a pull request pelias/kubernetes#126 for the same. Please let me know if anything else is required.

Thanks! 😃