pelias-deprecated / kubernetes

Tools for running Pelias services on kubernetes
MIT License
54 stars 47 forks source link

Kubernetes doc out of date #123

Closed ursNiemi closed 4 years ago

ursNiemi commented 4 years ago

Hey team!

Your Kubernetes documentation (https://github.com/pelias/kubernetes/blob/master/README.md) seems to be out of date:

if it is current directory (https://github.com/pelias/kubernetes), then the current directory is not compatible with Helm 3.

helm repo add kubernetes https://github.com/pelias/kubernetes leads to Error: looks like "https://github.com/pelias/kubernetes" is not a valid chart repository or cannot be reached: failed to fetch https://github.com/pelias/kubernetes/index.yaml : 404 Not Found

Or did I understand the instructions wrong somehow?

orangejulius commented 4 years ago

Hi @ursNiemi,

We haven't tested or really explored Helm 3 yet, so I would assume this chart doesn't yet support it. I'll throw a note in the README clarifying that we currently only test on Helm 2.

If you do have any success with Helm 3, be sure to let us know.

Mokto commented 4 years ago

I'm running Pelias with Helm3 and that works flawlessly ;)

deanshelton913 commented 4 years ago

Yeah the only diff really is that you need to omit the --name... Here is a command i am using to install with helm 3:

helm install pelias --namespace pelias . -f values.yaml -f my-overrides.yaml
skulos commented 4 years ago

I'm getting a silly error. I downloaded the repo:

~$ git clone https://github.com/pelias/kubernetes.git

Then I changed the directory

~$ cd kubernetes/

And the ran the helm command above:

~/kubernetes$ helm install pelias --namespace pelias . -f values.yaml
Error: template: pelias/templates/configmap.tpl:34:14: executing "pelias/templates/configmap.tpl" at <(.Values.api.targets.auto_discover) and (or (eq .Values.api.targets.auto_discover true) (eq .Values.api.targets.auto_discover false))>: can't give argument to non-function .Values.api.targets.auto_discover  

(NOTE: I've created a namespace pelias in kubernetes for this deplyment. Am I missing something?)

orangejulius commented 4 years ago

Helm 3 support status is now listed in the docs as of https://github.com/pelias/kubernetes/commit/25125b10a9a8dfcab19745305fc22de1cce8d386, so I think this issue is solved (at least in that the docs are up to date, we do want to get around to testing more thoroughly on Helm 3 someday).

@skulos sorry for the administrative noise, but can you please open a new issue to discuss your problem? I susupect the version of helm you are using is involved, so can you make sure to share that as well?

Thanks all!