search

pelias / api

HTTP API for Pelias Geocoder
http://pelias.io
MIT License
219 stars 162 forks source link

Run Docker image build _after_ release #1538

Closed orangejulius closed 3 years ago

orangejulius commented 3 years ago

As discussed in https://github.com/pelias/ci-tools/pull/7, we need to build the Docker images after we publish any new versions, so that the git tag for the version is present.

This lets us publish a Docker image corresponding to the tag.

orangejulius commented 3 years ago

Okay, as I suspected, simply making the docker images job depend on the npm-publish job means that it just doesn't run except on the master branch. Time to dive into the Github Action docs :)

orangejulius commented 3 years ago

Finally got this working, there's some fairly cryptic behavior from GitHub actions that has to be worked around: the if check is not the only thing that determines if a job will run, unless it includes one of the job status check functions