search

pelias / api

HTTP API for Pelias Geocoder
http://pelias.io
MIT License
221 stars 162 forks source link

Upgrade pelias-parser to v2.0.0 #1565

Closed missinglink closed 2 years ago

missinglink commented 2 years ago

As discussed in https://github.com/pelias/api/issues/1550, this PR takes us off a branch of pelias-parser and gets us back on the latest published version.

Noteworthy changes from pelias/parser being brought in:

Original commit to pin pelias-parser to a branch: https://github.com/pelias/api/commit/4061a2fb3b90d1949b5fbc74ac2ab3344a529e2d

closes https://github.com/pelias/api/issues/1550

orangejulius commented 2 years ago

Excellent. To be honest I think we can save everyone some trouble and not mark this as a breaking change. Unit number parsing has been removed in the API for some time, and even before then I'm pretty sure the queries in API didn't take advantage of any unit number that was found when parsing.

orangejulius commented 2 years ago

What testing do you think we should do before releasing this? The unit number removal is, of course, well tested at this point, but I'd be interested to see the impact of other changes (hopefully there are improvements!)

orangejulius commented 2 years ago

We've tested this out extensively across all our test suites and there are no major regressions. (We've catalogued the two small ones we found in https://github.com/pelias/parser/issues/151 and https://github.com/pelias/parser/issues/152).

There are probably quite a few improvements to parsing in the Netherlands especially, I think we'll be following up more closely on that.