Closed vinayakkulkarni closed 2 years ago
PS. I'm also planning on adding ESLint & Prettier in other repos as well :)
hi @vinayakkulkarni for such a large change I think we would want to use a bot account and consider the git history here.
My personal preference would be for https://standardjs.com, other contributors may have different preferences.
I suggest you first open an issue on pelias/pelias to discuss with the contributors of the project what they might want before opening more of these large code refactoring PRs.
Going to close this PR, and in the future I think that any wide-reaching style changing pull request would have to be made by a core maintainer.
Reasons being:
git blame
being made much less useful, though that's a bit of an aside)Of course feedback/discussion on what style to use is welcome from anyone, but we probably can't accept an outside PR to actually make the change.
:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change :rocket:
Instead of jshint, I added support for
prettier
&ESLint
Here's what actually got changed :clap:
Nothing as such, the source code is same but formatting is standardized
Here's how others can test the changes :eyes:
npm run lint:eslint
# Checks with ESLintnpm run lint:eslint:fix
# Fixes all issues with ESLintnpm run lint:prettier
# Checks with Prettiernpm run lint:prettier:fix
#Fixes all issues with Prettier