search

pelias / api

HTTP API for Pelias Geocoder
http://pelias.io
MIT License
218 stars 162 forks source link

Pin to an exact pelias-parser version (2.1.0) #1585

Closed orangejulius closed 2 years ago

orangejulius commented 2 years ago

Historically we've specified most Pelias NPM dependency versions using the caret (^) range, but because the Pelias Parser can cause differences in acceptance-test results for any change (minor or even bug fix), we've kept that dependency in particular pinned to a specific version so we can control upgrades more carefully.

Recently, we were on a hotfix branch of the parser, but while switching back , we switched to using a caret range.

While manually bumping the version on a frequent basis is a bit annoying, it helps avoid any chance that unexpected or untested parser changes will find their way into the API releases.

This change brings us back to a pin of the current latest version of the Pelias Parser.

orangejulius commented 2 years ago

Yeah, agreed. In some ways it might have been good to put the parser code in the API repository. But there are also a lot of good reasons to not have done that.

A bunch of manual version bumping work isn't the worst outcome.