search

pelias / api

HTTP API for Pelias Geocoder
http://pelias.io
MIT License
221 stars 162 forks source link

simplified dedupe + preserve order #1612

Closed missinglink closed 2 years ago

missinglink commented 2 years ago

an extension to https://github.com/pelias/api/pull/1607 which preserves ordering of synonymous records (ie. the lower ordinal position is inherited by the superior record).

orangejulius commented 2 years ago

Cool, this fixes the example I had in mind, will run it through the full test suite to see if it looks good overall.

orangejulius commented 2 years ago

All our acceptance testing shows this is either a no-op or a slight improvement. I think this is good to go, and then we can start evaluating the other deduplication related PRs: https://github.com/pelias/api/pull/1606 and https://github.com/pelias/api/pull/1371, since their full benefits are only unlocked with this change to the deduplication logic.