pelias / api

HTTP API for Pelias Geocoder
http://pelias.io
MIT License
219 stars 163 forks source link

Search for federal states of Germany in German language #1629

Closed dawidl11 closed 1 year ago

dawidl11 commented 2 years ago

Hi there,

I have encountered a problem when using Pelias Snapshot.

What am I using?

I have created a standard Pelias snapshot (data sources: OSM, Opensearch, Geonames, WhosOnFirst).

What is the problem? I want to specify now in my structured query (under the attribute "Region") the German federal state. In doing so, I enter the German name of the federal state (e.g. "Sachsen"). When I do this, no correct result is returned. However, if I enter the same query with the English name of the state ("Saxony"), a correct result is returned.

My question: Is it possible to set Pelias to correctly identify German state names in the queries?

Many thanks in advance for the answers!

missinglink commented 2 years ago

Hi @dawidl11

Which API are you using? I'm guessing /v1/autocomplete?

Which language is your computer set to? ie. What Accept-Language header does your browser send?

dawidl11 commented 2 years ago

Hi @missinglink , The problem was actually with Accept-Language. Thanks for the hint.

missinglink commented 2 years ago

@dawidl11 please close the issue if it's resolved

dawidl11 commented 2 years ago

At first we thought it was actually due to our "Accept-Language". But now we have also checked it with German as "Accept-Language" and unfortunately we get the same results. Also with the following Pelias API: https://api.geocode.earth . Here is an example of a request:

So it looks like a general problem. Could this please be reviewed again? Many thanks in advance!

missinglink commented 2 years ago

See this recently merged PR for more context, this is much closer to being resolved now.

https://github.com/pelias/wof-admin-lookup/pull/314

dawidl11 commented 2 years ago

Thank you for the link. This looks interesting and is in line with what we have also been investigating. Is it also possible to estimate approximately when the adjustments will be made for German federal states, or is that rather difficult to say?

missinglink commented 1 year ago

The issue with German Federal States should now be resolved via https://github.com/pelias/wof-admin-lookup/pull/317

missinglink commented 1 year ago

https://github.com/pelias/acceptance-tests/pull/567

dawidl11 commented 1 year ago

This is very good news. Thanks for the information @missinglink