:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change :rocket:
Addresses from OpenAddresses can override parent place name (such as postalcode). When this happens, we don't know where the postalcode came from, especially if there was one from another source (like WOF).
Also, since postalcodes are part of an document's parents, not having a gid makes the API less consistent.
Here's what actually got changed :clap:
In renamePlacenames middleware, I added an option that allows us to add/override the postalcode gid. Thanks to this, we will know where the data comes from.
:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change :rocket:
Addresses from OpenAddresses can override parent place name (such as
postalcode
). When this happens, we don't know where the postalcode came from, especially if there was one from another source (like WOF).Also, since postalcodes are part of an document's parents, not having a gid makes the API less consistent.
Here's what actually got changed :clap:
In
renamePlacenames
middleware, I added an option that allows us to add/override the postalcode gid. Thanks to this, we will know where the data comes from.Here's how others can test the changes :eyes:
You can try with
815 Tennessee St, San Francisco, CA 94107, États-Unis
where thepostalcode_gid
will beopenaddresses:address:us/ca/san_francisco:819b088d2837cf5d
Maybe when the postalcode is already present in the parent object we may not override it with OA data ?
Feel free the close the PR if this is not valuable for the project :smile: