search

pelias / api

HTTP API for Pelias Geocoder
http://pelias.io
MIT License
218 stars 162 forks source link

fix: diffPlaces diacritics test case #1645

Closed wasi-m closed 1 year ago

wasi-m commented 1 year ago

Signed-off-by: wasim wasim.tamboli@olacabs.com

Here's the reason for this change :rocket:

:wave: Hi fixed issue https://github.com/pelias/api/issues/1644

Here's what actually got changed :clap:

Changed the expected result in the test case for diffPlaces

Here's how others can test the changes :eyes:

To check, run the test cases PELIAS_CONFIG=./test/test-pelias-config.json node --trace-uncaught test/unit/run.js | npx tap-dot

orangejulius commented 1 year ago

Thanks for this PR, we've actually fixed the test by pinning to a version of the require-accents NPM module that behaves as we believe is correct and is expected by the unit tests. See #1655 :)