remove Joi? - Githubissues

pelias / config

Configuration file for Pelias

8 stars 33 forks source link

Open missinglink opened 3 years ago

missinglink commented 3 years ago

I noticed that removing this line doesn't seem to affect the the tests or functionality of this module?

I'm not super familiar with Joi so I wasn't able to establish if it's safe to remove it? There doesn't seem to be any Joi config in this module.

@orangejulius do you remember how this works?

orangejulius commented 3 years ago

I think you're right, we can remove that line.

The way the config validation works is:

Modules that need config validation depend on Joi and define a schema (for example the API)
When calling pelias-config.generate(), the schema object is passed in, and then validated with Joi.

I tested things out, and we do need pelias/config to depend on Joi, for the tests if nothing else.