search

pelias / csv-importer

Import arbitrary data in CSV format to Pelias
MIT License
23 stars 22 forks source link

feat(json): Allow empty addendum json #81

Closed blackmad closed 4 years ago

blackmad commented 4 years ago

I had a csv import that was silently failing because my addendum_json_XXX field was empty in some rows.

This change allows for empty values in addenum_json_XXX fields and adds a lot of tests for both that field and other json fields in csv import

In a separate change, I will attempt to print out badRecordCount somewhere, and in another I will propose we log failed rows to stderr

Joxit commented 4 years ago

You did not remove lines with console.log? Don't forget to use Conventional Commit to trigger release... Use squash instead of merge

blackmad commented 4 years ago

Apologies I thought I did push the console log. My computer just restarted for a forced upgrade. Will check again when it completes.

Also apologies on using merge instead of squash.

What’s conventional commit?

On Fri, Oct 9, 2020 at 6:34 PM Jones Magloire notifications@github.com wrote:

You did not remove lines with console.log? Don't forget to use Conventional Commit to trigger release... Use squash instead of merge

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pelias/csv-importer/pull/81#issuecomment-706428056, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMZMF3HWQDHKYSFJCGXATSJ6FXBANCNFSM4SKOTFYA .

-- David Blackman creative technologist & wandering help me find my purpose http://purpose.blackmad.com

blackmad commented 4 years ago

Conventional commit = semantic versioning, got it.

I thought that’s what I was doing by renaming the commit to feat(Json): - should I have done something different?

On Fri, Oct 9, 2020 at 6:35 PM David Blackman whizziwig@gmail.com wrote:

Apologies I thought I did push the console log. My computer just restarted for a forced upgrade. Will check again when it completes.

Also apologies on using merge instead of squash.

What’s conventional commit?

On Fri, Oct 9, 2020 at 6:34 PM Jones Magloire notifications@github.com wrote:

You did not remove lines with console.log? Don't forget to use Conventional Commit to trigger release... Use squash instead of merge

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pelias/csv-importer/pull/81#issuecomment-706428056, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMZMF3HWQDHKYSFJCGXATSJ6FXBANCNFSM4SKOTFYA .

-- David Blackman creative technologist & wandering help me find my purpose http://purpose.blackmad.com

-- David Blackman creative technologist & wandering help me find my purpose http://purpose.blackmad.com

Joxit commented 4 years ago

The Conventional Commits specification is a lightweight convention on top of commit messages. It provides an easy set of rules for creating an explicit commit history; which makes it easier to write automated tools on top of. This convention dovetails with SemVer, by describing the features, fixes, and breaking changes made in commit messages.

This means that the first line of the commit should use the conventional commit spec. Here, you use the Conventional Commit on the PR title and not on your commits.

And in the merge commit, feat(json) is located in the second line of the commit message and not in the first one.