pelias / docker

Run the Pelias geocoder in docker containers, including example projects.
MIT License
330 stars 223 forks source link

Wrong search result #281

Open artemChernitsov opened 2 years ago

artemChernitsov commented 2 years ago

Describe the bug

Incorrect locality in search results in WI, USA (North America project)

Steps to Reproduce Just enter in search "639 Baxter Drive Mukwonago" https://www.mapzen.com/products/search/geocoding/?query=639%20Baxter%20Drive%20Mukwonago&endpoint=autocomplete&gid=whosonfirst%3Alocality%3A101732227&selectedLat=42.86211&selectedLng=-88.32353&lng=-88.32979&lat=42.85187&zoom=13.377551249626974

Expected behavior Locality must be Mukwonago, not Waterford.

missinglink commented 2 years ago

this is due to there being two overlapping polygons:

both claim to be sourced from uscensus which usually doesn't have overlapping polygons 🤔 note there is also the localadmin -> https://spelunker.whosonfirst.org/id/404495653/

I'm not familiar with the area, please open an issue on the whosonfirst-data repo to see if it can be fixed: https://github.com/whosonfirst-data/whosonfirst-data/issues

missinglink commented 2 years ago

You may find the new compare app easier to use than the old Mapzen homepage: https://pelias.github.io/compare/#/v1/autocomplete?text=639+Baxter+Drive+Mukwonago

missinglink commented 2 years ago

I just had a look again and the polygons don't overlap:

Screenshot 2022-01-20 at 11 07 11

I think there is something else going on, possibly that this has been fixed and we haven't imported the new data, will let you know.

missinglink commented 2 years ago

the issue was in our postal-cities mapping, I've fixed it via https://github.com/pelias/wof-admin-lookup/commit/0ea09e0ab8531f282f8b4e81aeba2997c65d948d but it will take some time to propagate through the stack

artemChernitsov commented 2 years ago

Thanks @missinglink Should I make a rebuild of all my Pelias instance? Or maybe exist some other mechanism to safely update my Pelias instance?

missinglink commented 2 years ago

There isn't a method to update an existing instance, it always requires a rebuild by design.

Because of the dependencies, this change won't be pulled into the pelias/openaddresses:master docker image until the next merge on the master branch of that repo.

It's a fair bit of work to rebuild for one locality name change, I'd generally just recommend waiting a bit longer and rebuilding every few months unless it's really important.

artemChernitsov commented 2 years ago

@missinglink unfortunately it's very important to our app which using Pelias, can I manually make changes in my instance and make pelias preparation for wof, and then import all datasets again to save time of preparing?

missinglink commented 2 years ago

I just merged a PR on pelias/openaddresses, once this job completes then you can pull the latest docker images and rebuild https://github.com/pelias/openaddresses/actions/runs/1723109743