search

pelias / docker

Run the Pelias geocoder in docker containers, including example projects.
MIT License
339 stars 226 forks source link

No support for docker compose v2 #315

Open arnesetzer opened 1 year ago

arnesetzer commented 1 year ago

Describe the bug On a system with only docker compose (v2) installed every command fails due to missing support for docker compose (v2)

/home/arne/docker/cmd/docker.sh: Line 20: docker-compose: Command not found.

The line is just an example and can be replaced with every function in ./docker/cmd/docker.sh

Steps to Reproduce Steps to reproduce the behavior:

  1. Install docker and docker compose as recommanded (https://docs.docker.com/compose/install/linux/#install-using-the-repository)
  2. Follow the install script
  3. Import fails on pelias compose pull

Expected behavior Since the last release for compose v1 was in 2021 and the installation guide heavily recommands to use v2 I expect that pelias works out of the box with docker compose v2.

Environment (please complete the following information):

Pastebin/Screenshots X

Additional context Before opening a PR with the compsoe v2 commands: I guess commands also should also work with compose v1 (backwards compability)?

References

Related PR: https://github.com/pelias/docker/pull/303

borys-spiridonov-yal commented 1 year ago

I'm still getting the error "docker-compose: command not found" when trying to start Pelias on the system with docker-compose v2

# pelias compose pull
/mnt/pelias/osm-deploy/pelias/pelias-docker/cmd/docker.sh: line 20: docker-compose: command not found

# docker compose version
Docker Compose version v2.23.0
arnesetzer commented 1 year ago

See #303 for a working solution