pelias / docker

Run the Pelias geocoder in docker containers, including example projects.
MIT License
314 stars 217 forks source link

Remove deprecated version tag from compose files #346

Open arnesetzer opened 2 months ago

arnesetzer commented 2 months ago

:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change :rocket:

With docker compose version v2.26 (some threads on github say since v2.25, but I didn't test that) compose throws a warning if the compose file still has a version tag. WARN[0000] /home/geo-coder/docker/projects/[PROJECT NAME]/docker-compose.yml: 'version' is obsolete (https://docs.docker.com/compose/compose-file/04-version-and-name/)


Here's what actually got changed :clap:

missinglink commented 2 months ago

Interesting, thanks.

So removing this would be a breaking change for older versions, do you know which versions?

For now I'd prefer displaying a warning on newer versions over a breaking change for older versions.

arnesetzer commented 2 months ago

According to some issues on the docker cli it is deprecated since the jump from docker compose v1 to compose v2. (https://github.com/docker/compose/issues/8950)

I agree with you that this on very low priority. We can leave that as a draft until docker compose will throw an error if the version tag is set.