search

pelias / geonames

Import pipeline for geonames in to Pelias
https://pelias.io
MIT License
43 stars 37 forks source link

Remove streaming downloader #383

Open orangejulius opened 4 years ago

orangejulius commented 4 years ago

In addition to a standard download, this importer supports streaming data directly from a ZIP archive over HTTP.

When we originally wrote it, we thought the idea of every part of Pelias supporting a "streaming" mode would lead to great functionality. In practice, it just made things brittle, and we generally prefer a discrete download step followed by an import process that does not use the network (except possibly to contact Elasticsearch).

Removing this importer's streaming mode would simplify the code and remove lots of issues we've had with streaming ZIP files, which are inherently hard to stream.

orangejulius commented 4 years ago

Somehow I originally made this issue in the pelias/docker repository. It was supposed to go here, in the Geonames importer repository. :man_shrugging:

missinglink commented 4 years ago

Ooh transferring issues between repos... fancy!