search

pelias / interpolation

global street address interpolation service (beta)
https://interpolation.demo.geocode.earth
MIT License
58 stars 29 forks source link

Skip importing OSM #290

Open emacgillavry opened 2 years ago

emacgillavry commented 2 years ago

With https://github.com/pelias/interpolation/commit/c7122d50db015c99b5ef34e0ab91e3370c701e5b, we can no longer skip importing OSM into the address.db. We have custom countrywide.csv and polylines.0sv files and were able to obtain the address.db and street.db database files without any need for an OSM data file. Can we add configuration to pelias.json so interpolation would know what inputs to skip?

Current kludge is to provide an empty netherlands-latest.osm.pbf file

missinglink commented 2 years ago

Agh I didn't consider that case, I suspect that having the configuration in pelias.json would be hard to pass down to this bash script without considerable refactoring.

If I recall correctly, the intention of the fatal errors at the top of that bash script was to indicate to the user that the required files were missing, to save them the time & heartache of running the whole build before catching their error.

I wonder if we could change those fatal errors to warnings instead, and do nothing when no file is found.

emacgillavry commented 2 years ago

From your suggestion we'd just drop the exit 1. The user would still receive feedback about the missing files, but the build would proceed: if the file is empty (the kludge we use now) or does not exist (our way of working before https://github.com/pelias/interpolation/commit/c7122d50db015c99b5ef34e0ab91e3370c701e5b) the build.sh script runs ok.