search

pelias / interpolation

global street address interpolation service (beta)
https://interpolation.demo.geocode.earth
MIT License
58 stars 29 forks source link

The osm.pbf file name is hard-coded into the `conflate_osm.sh` script as "planet.osm.pbf" #300

Closed coussens closed 3 hours ago

coussens commented 4 hours ago

Hello -- First off, I wanted to say thanks for creating and maintaining such an awesome open-source product!

I noticed the following issue when trying to run interpolation for a less-than-planet build (in docker): the osm.pbf file name is hard-coded into the conflate_osm.sh script

# full path to the .osm.pbf file we would like to import
PBF2JSON_FILE=${PBF2JSON_FILE:-"planet.osm.pbf"};

So if the user has a osm.pbf file with any other name (e.g., north-america-latest.osm.pbf), interpolation for OSM won't run. It seems to me like a better approach would be to read the file name from within the OSM data directory, then use this as the PBF2JSON_FILE environment var -- but let me know if this isn't the case!

coussens commented 3 hours ago

Sorry, my bash knowledge is obviously lacking -- I didn't realize that this would only overwrite the env var if it weren't already in place, so I'm closing this issue. There must be another reason why my build isn't conflating the OSM data -- likely user error! =)