Open Joxit opened 1 year ago
Hi there, I hope you are doing well
I was working on a refactoring to avoid duplicate names and wonder why do we need dedupeNameAndFirstLabelElement function...
dedupeNameAndFirstLabelElement
I found this test which requires the use of the hierarchy country name, this test comes from the v1.0.0
hierarchy country name
https://github.com/pelias/labels/blob/e60f6b10008b645429c151d5b725ae77320856a2/test/labelGenerator_default.js#L236-L245
In my refactoring, I'm trying to use the name of the object instead of the hierarchy, even if its a coarse layer.
Hi there, I hope you are doing well
I was working on a refactoring to avoid duplicate names and wonder why do we need
dedupeNameAndFirstLabelElement
function...I found this test which requires the use of the
hierarchy country name
, this test comes from the v1.0.0https://github.com/pelias/labels/blob/e60f6b10008b645429c151d5b725ae77320856a2/test/labelGenerator_default.js#L236-L245
In my refactoring, I'm trying to use the name of the object instead of the hierarchy, even if its a coarse layer.