search

pelias / model

Pelias data models
6 stars 17 forks source link

do not allow urls in name and address fields #115

Closed missinglink closed 5 years ago

missinglink commented 5 years ago

We recently discovered some open-data which incorrectly contains URLs in the name & housenumber fields. Unfortunately, this seems to be a common problem in openstreetmap due to human error.

This PR enforces a regex check on name and address fields to ensure that they do not contain URLs.

missinglink commented 5 years ago

No attempts are made to try and correct the data programmatically, I've gone through and hand-edited a bunch of OSM data to fix the ones I am aware of, I'm sure there are loads more.

missinglink commented 5 years ago

For some reason the integration between Travis & Github seems to be broken, I can see that the tests passed here https://travis-ci.org/pelias/model/builds/506714451 so I'm going to merge this using admin privileges.

orangejulius commented 5 years ago

:+1: on this PR

I've been noticing lots of Travis/Github integration issues. I'm not sure what the cause is but it's definitely annoying