pelias / openaddresses

Pelias import pipeline for OpenAddresses.
MIT License
51 stars 43 forks source link

feat(deps): Remove fs-extra package #459

Closed orangejulius closed 4 years ago

orangejulius commented 4 years ago

We generally only use the fs-extra package for its mkdir -p style convenience wrapper, which can now easily be done with the stock fs module.

This removes usage of the fs-extra module and replaces it with native alternatives.

Closes https://github.com/pelias/openaddresses/pull/458

orangejulius commented 4 years ago

Update, we can't quite merge this yet. We use the recursive remove functionality of fs-extra, which can't be replicated in the Node.js 10 fs module

missinglink commented 4 years ago

Seems the recursive flag was backported to 10 @orangejulius

orangejulius commented 4 years ago

That's for mkdir. We need it for rmdir.

Of course we could implement it ourselves, but it seems easiest to wait for Node.js 10 to be dropped. Node.js 14 should come out next month, so it won't be too long.