search

pelias / openaddresses

Pelias import pipeline for OpenAddresses.
MIT License
51 stars 43 forks source link

Add support for OpenAddresses geojson format #476

Closed Joxit closed 3 years ago

Joxit commented 3 years ago

:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change :rocket:

I wanted to retrieve fresh data from OpenAddresses and saw that they had completely changed their data format. The data is now available on batch.openaddresses.io and they serve ndjson instead of csv.

Here's what actually got changed :clap:

I've updated the importer to support both csv and geojson files at import time.

orangejulius commented 3 years ago

Aw yes! I was wondering when someone was going to mention this big change :)

We'll test this out ASAP but it looks like the perfect approach: convert the incoming geojson to essentially the CSV format. That should work as long as the new format doesn't add interesting new data that we can't handle with the old CSV format.

Thanks @Joxit ❤️

Joxit commented 3 years ago

You are welcome :smile:

It was a big surprise when I saw the new data page UI and format :sweat_smile: I did not change the download part because it's a bit more complicated with the new API to get filtered data... :confused:

Joxit commented 3 years ago

Updated, thanks for your review :wink:

Time to sleep now :sleeping:

missinglink commented 3 years ago

Haha the perils of timezones, turn your notifications off and go to bed! ;)

orangejulius commented 3 years ago

Wow, @Joxit. Coding 24/7 I see

Joxit commented 3 years ago

:heart: