since we're using child_process.exec the stdout is buffered until the process exits, if the buffer (1MB by default) fills up then an error occurs.
we're not using the return value of child_process.exec (from what I could tell), so adding --only-show-errors suppresses it, while also not having to worry about conflicting/duplicate --no-progress flags provided by the user.
if we would like to return regular status reports of the file as it downloads then we would need to change child_process.exec to child_process.spawn and refactor accordingly, the latter allows customisation of the stdio config for stdout whereas the former does not.
as discussed in https://github.com/pelias/docker/issues/266 the
aws s3 cpcommand outputs regular progress information tostdout.since we're using
child_process.execthestdoutis buffered until the process exits, if the buffer (1MB by default) fills up then an error occurs.we're not using the return value of
child_process.exec(from what I could tell), so adding --only-show-errors suppresses it, while also not having to worry about conflicting/duplicate--no-progressflags provided by the user.if we would like to return regular status reports of the file as it downloads then we would need to change
child_process.exectochild_process.spawnand refactor accordingly, the latter allows customisation of thestdioconfig forstdoutwhereas the former does not.resolves https://github.com/pelias/docker/issues/266