recordStream: document ids should not end with `.geojson`

pelias / openaddresses

Pelias import pipeline for OpenAddresses.

MIT License

51 stars 43 forks source link

recordStream: document ids should not end with `.geojson` #512

Closed Joxit closed 1 year ago

Joxit commented 1 year ago

:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change :rocket:

The id of documents imported from GeoJSON contains .geojson. When we import csv, the extension is removed from the prefix. So I brought the functionality back to geojsons.

Here's how others can test the changes :eyes:

I added 3 tests based on CSV

missinglink commented 1 year ago

looks good, thanks & happy new year!

it looks like the OA project has finally moved away from CSV so this work to get Pelias ported over to GeoJSON is now much more urgent.

Joxit commented 1 year ago

Heya, thanks happy new year! 😁

Yeah, I downloaded the bundle via the GUI, I don't know if the "by files" feature is still working in pelias 😕