search

pelias / openstreetmap

Import pipeline for OSM in to Pelias
MIT License
112 stars 72 forks source link

remove language codes we never used #543

Closed missinglink closed 3 years ago

missinglink commented 3 years ago

These language codes (international, national, old ... etc) were included in the build years ago and never utilised in query logic.

Let's remove them from the index since they're just taking up space?

note: I had to change the tag mapper slightly to ensure the work from https://github.com/pelias/openstreetmap/pull/498 didn't break.

orangejulius commented 3 years ago

Very nice, this should save us a bit of space in the index.

missinglink commented 3 years ago

Oh sorry, I got a bit trigger happy ;) The main reason was that this shouldn't cause any regressions.

Prior to merging this int_name was being stored in name.international in the schema, which no-one was using 😆 So we can have a new PR to add that if it's useful, but this PR shouldn't have removed anything which was being used.

We do actually use int_name and official_name in the case where name.default hasn't been set by another method, but we don't currently use them as aliases for name.default.

Joxit commented 3 years ago

Ha ha don't worry :p

Oh yes you're right they are used as fallback, so it's totally OK :smile: