search

pelias / openstreetmap

Import pipeline for OSM in to Pelias
MIT License
112 stars 72 forks source link

popularity: do not penalize abandoned:amenity=place_of_worship #552

Closed missinglink closed 3 years ago

missinglink commented 3 years ago

As per https://github.com/pelias/geonames/pull/394 this PR is to fix the scoring of the query for "Angkor Wat".

Pelias is currently giving the OSM record a negative popularity as it's tagged abandoned:amenity=place_of_worship.

We originally assumed that abandoned:amenity meant it was no longer important but that doesn't seem to be the case, either it's mis-tagged or we're interpreting the tag wrong. The OSM wiki seems to confirm our view, but who knows 🤷‍♂️ .

This PR maintains the negative scoring for all abandoned and abandoned:* tags with a single exception for abandoned:amenity=place_of_worship.

Currently that only affects 421 records so it's unlikely to have any negative side-effects.

missinglink commented 3 years ago

Also worth noting that users who enable the config option imports.openstreetmap.removeDisusedVenues would previously have had that record omitted from the index, with this change it would be included.

missinglink commented 3 years ago

I spent some more time looking at this and TBH it's really not clear how we (and other geocoders) should interpret abandoned:amenity.

The wiki says:

For example, an abandoned shop which still carries a name sign might be tagged as... abandoned:shop=doityourself, name=Holby Tool Supplies ...which makes it unavailable to programs which locate shops, and unlikely to be displayed as a shop in any default renderings. The name is still relevant, and will still be searchable. If the shop is repaired and reopened, it's a simple matter to undo the prefixing.

Although I disagree with the comment "The name is still relevant, and will still be searchable". I think the author of that comment is specifically referring to it still being returned by nominatim for mappers to find and edit.

It's not clear if Pelias is a "program which locates shops" or a program which makes things "searchable" in that context.

A large number of places tagged abandoned:amenity appear to be incorrectly tagged abandoned when they should have been tagged disused. IMO they shouldn't be considered 'current' or 'active' enough for inclusion in the index, this confusion makes the tag quite unreliable to depend on in any meaningful way.

However, in OSM there's an exception to every rule, there seem to be some places tagged abandoned:amenity=place_of_worship which are still culturally relevant, such as Angkor Wat or Christchurch Cathedral.

missinglink commented 3 years ago

As this change only currently affects 421 records I'm happy to merge it as-is. I'm open to making changes to how we interpret abandoned:* in the future.