Category does not get mapped as defined in category_map.js

[tobiasbartsch]

Describe the bug Categories sometimes do not get assigned as defined in category_map.js Here are two examples:

• amenity:restaurant should be mapped to 'food','retail','nightlife'; however, for at least one example this does not appear to happen: no category is assigned to https://www.openstreetmap.org/way/840223953
• shop:bakery should be mapped to 'food'. This does not happen for node https://www.openstreetmap.org/node/7851477778

Steps to Reproduce

• For https://www.openstreetmap.org/way/840223953 : My local import of OSM data into Pelias (using docker) does not create 'food','retail','nightlife' categories for this way. The Pelias implementation at https://pelias.github.io/compare/#/v1/search?size=1&text=SmokeHouse+Tailgate+Grill%2C+Mamaroneck+%2C+NY does not contain these categories either.
• For https://www.openstreetmap.org/node/7851477778 : My local import of OSM data into Pelias (using docker) does not create a 'food' category for this node

Expected behavior The correct categories should be mapped to these addresses.

Environment (please complete the following information):

• OS: Linux
• Docker versions: Docker version 23.0.4, build f480fb1

Additional context Is there something that I am fundamentally misunderstanding of how category mapping should work?

Thank you very much for your help!

[missinglink]

Can you please confirm this is a bug in the code rather than an issue with how your environment is configured?

There are unit tests which you can edit and run using the command npm test, I'd be happy to have a look at any failing tests.

https://github.com/pelias/openstreetmap/blob/master/test/stream/category_mapper.js

Is there something that I am fundamentally misunderstanding of how category mapping should work?

What is your understanding? It needs to be configured prior to running the import and should work as illustrated in the tests

[tobiasbartsch]

Hi @missinglink , thank you so much for your quick reply and for helping with this.

I installed Pelias using Docker and did not modify any of its settings -- do you think I need to make changes to the defaults to make category mapping work?

I ran the unit tests by attaching to the pelias/openstreetmap docker container and running npm test -- they all passed, so whatever is happening here is not caught by them. Is there any integration test we could run to determine whether a specific node is imported with correct category mapping?

When you say "it needs to be configured prior to running the import", do you mean I need to change any of the configurations or should they work as defined in https://github.com/pelias/openstreetmap/blob/master/test/stream/category_mapper.js (which they don't seem to do in an integrated system / outside of the unit tests)

For reference, here are the OSM settings Pelias shipped with for the north-america region:

    "openstreetmap": {
      "download": [
        { "sourceURL": "http://download.geofabrik.de/north-america-latest.osm.pbf" }
      ],
      "leveldbpath": "/tmp",
      "datapath": "/data/openstreetmap",
      "import": [{
        "filename": "north-america-latest.osm.pbf"
      }]
    },

and here is the relevant entry from the docker-compose file:

 openstreetmap:
    image: pelias/openstreetmap:master
    container_name: pelias_openstreetmap
    user: "${DOCKER_USER}"
    volumes:
      - "./pelias.json:/code/pelias.json"
      - "${DATA_DIR}:/data"
      - "./blacklist/:/data/blacklist"

[missinglink]

Categories are not shown by default in the geojson response, are you specifying the categories querystring param?

[tobiasbartsch]

ohh I had no idea. Sorry for filing this as a bug -- it now works. Is this in the docs somewhere? I thought I had read it all...

[tobiasbartsch]

@missinglink do you know whether I can make categories also show up in the results of the reverse endpoint?

[missinglink]

The categories feature was never officially released despite being in the codebase for like 5+ years.

The categories param can be used as a filter such as categories=nightlife or without the value such as above to just enable them in the output.

What I was referring to earlier was that it's possible to customize the category map by telling docker to use a local copy of the mapping script through what's called a bind mapping in docker.

That allows advanced users to create their own custom categories, but like I said it's more advanced.

[missinglink]

related https://github.com/pelias/api/issues/1405

[missinglink]

I don't think it's enabled for reverse and I don't recall why, maybe it should be, I might have mentioned it in the issue above

[tobiasbartsch]

Got it, thank you very much. It would be very useful to have this in reverse (in order to determine what category of places is close to a lat/lng). Closing this now, and might comment on the related issue. Thanks for all your help!