remove japan as a locality

pelias / parser

natural language classification engine for geocoding

https://parser.demo.geocode.earth

MIT License

55 stars 27 forks source link

remove japan as a locality #118

Closed blackmad closed 3 years ago

blackmad commented 4 years ago

this change was spurred by debugging "universal studios japan"

as far as I can tell, there are 5 localities in pelias named japan

two in indonesia don't seem to be real
one in montenegro is tiny
two in US are both tiny

missinglink commented 4 years ago

@blackmad can you please rebase this against master? it has merge conflicts so it can't be merged as-is 😱

missinglink commented 3 years ago

heya, just a heads-up that this PR didn't generate a new npm version of the package: https://www.npmjs.com/package/pelias-parser

a semantic-release commit message is strictly required to trigger a new npm version, I usually either do this in the commits themselves (as a contributor) or in a 'squash commit' message as a maintainer.

Not a big deal, the feature will be included in the next release, if it's required earlier we can add an empty commit.

Joxit commented 3 years ago

Oh yes sorry, it's my fault, I've forgotten the fix: prefix when I squashed commits... :confused: