Closed missinglink closed 3 years ago
The build is was failing because Circle-CI
has been removed from this project but it still thinks it's active.
I've just removed the webhooks for CircleCI
and TravisCI
, so it's fixed for next time, this one will require a manual admin override.
@joxit are "Esplanade/Esplanades" common street types in French? If not we could remove these too:
git grep -i esplanade
...
resources/libpostal/dictionaries/fr/street_types.txt:esplanade|esp
resources/libpostal/dictionaries/fr/street_types.txt:esplanades|esps
another one we might consider removing?
resources/whosonfirst/dictionaries/locality/name:fra_x_preferred.txt:broadway
Yes, Eslplanade is a common street/place type in French, always in the singular (without s) Some usage examples:
Esplanade de la Liberté
Esplanade du Géneral de Gaulle
Esplanade Méditerranée
Broadway can be safely removed :smile:
Removed locality/name:fra_x_preferred = Broadway
via rebase.
Removed libpostal/dictionaries/fr/street_types.txt = esplanades|esps
via rebase.
I think this is good to go @Joxit? It comes with a fair few test cases.
this PR resolves the issue discussed in https://github.com/pelias/parser/issues/140
it works by:
street
composite classifier config to re-classifystreet_proper_name+street_suffix
andstreet_proper_name
asstreet
no regressions, cc @kochis resolves https://github.com/pelias/parser/issues/140