refactor: use ESLint & Prettier instead of `jshint` - Githubissues

pelias / parser

natural language classification engine for geocoding

https://parser.demo.geocode.earth

MIT License

55 stars 27 forks source link

refactor: use ESLint & Prettier instead of `jshint` #154

Closed vinayakkulkarni closed 2 years ago

vinayakkulkarni commented 2 years ago

:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change :rocket:

Instead of jshint, I added support for prettier & ESLint

Here's what actually got changed :clap:

Nothing as such, the source code is same but formatting is standardized

Here's how others can test the changes :eyes:

npm run lint:eslint # Checks with ESLint
npm run lint:eslint:fix # Fixes all issues with ESLint
npm run lint:prettier # Checks with Prettier
npm run lint:prettier:fix #Fixes all issues with Prettier
[x] Ref: https://github.com/pelias/api/pull/1579

orangejulius commented 2 years ago

Going to close this PR, and in the future I think that any wide-reaching style changing pull request would have to be made by a core maintainer.

Reasons being:

We'd want to make the change from a bot account to avoid massively upsetting contributor stats (we'd also use the amazing .git-blame-ignore-revs file to avoid git blame being made much less useful, though that's a bit of an aside)
It's impossible to review a 17k line change, so instead we would have to programmatically generate the change on a trusted machine.

Of course feedback/discussion on what style to use is welcome from anyone, but we probably can't accept an outside PR to actually make the change.