Production branch can't find WOF files

[nilsnolde]

For anyone experiencing a similar issue: The production branch is not entirely up-to-date with WOF changes yet, similar to a closed issue at WOF importer.

However, master branch works as expected, as @orangejulius suggested.

[orangejulius]

Hey @nilsnolde, There's almost no logic in this repository, it all lives in wof-admin-lookup. My guess is an rm -rf node_modules; npm install will fix everything on either branch, since NPM won't automatically upgrade an older version of dependency modules.

If you could confirm that's the case, I would appreciate it.

The pip-service production Docker image, however, is broken, and we'll fix that soon.

[nilsnolde]

Thanks @orangejulius,

unfortunately no luck:

git checkout production
sudo rm -rf node_modules/; npm install
sudo systemctl restart pelias-pip.service
sudo systemctl status pelias-pip.service

Example log:

Sep 30 15:55:20 ors-pelias-importer npm[6793]: 2018-09-30T15:55:20.024Z - warn: [wof-pip-service:master] unable to locate /srv/pelias_importer_ext/data/wof/meta/wof-region-latest.csv

Switching back to master and repeating the above steps works as expected.

[orangejulius]

That's very weird. Are you on the latest production code?

Can you please run npm ls | grep pelias- on both the master and production branches after repeating those steps, and share the output here?

[nilsnolde]

Jup, right, not the latest wof-admin-lookup version.

ubuntu@ors-pelias-importer:~/pip-service$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

ubuntu@ors-pelias-importer:~/pip-service$ npm ls | grep pelias-
pelias-pip-service@0.0.0-development /home/ubuntu/pip-service
├─┬ pelias-logger@1.3.0
│ ├─┬ pelias-config@3.5.0
├─┬ pelias-mock-logger@1.4.0
├─┬ pelias-wof-admin-lookup@4.13.1
│ ├── pelias-config@3.5.0 deduped
│ ├── pelias-logger@1.3.0 deduped
│ ├─┬ pelias-microservice-wrapper@1.6.0
│ │ ├── pelias-logger@1.3.0 deduped
│ ├─┬ pelias-whosonfirst@2.25.0
│ │ ├─┬ pelias-blacklist-stream@1.0.1
│ │ │ ├── pelias-config@3.5.0 deduped
│ │ ├── pelias-config@3.5.0 deduped
│ │ ├─┬ pelias-dbclient@2.6.0
│ │ │ ├── pelias-config@3.5.0 deduped
│ │ │ ├── pelias-logger@1.3.0 deduped
│ │ ├── pelias-logger@1.3.0 deduped
│ │ ├─┬ pelias-model@5.7.1
│ │ │ ├── pelias-config@3.5.0 deduped

ubuntu@ors-pelias-importer:~/pip-service$ git status
On branch production
Your branch is up-to-date with 'origin/production'.

ubuntu@ors-pelias-importer:~/pip-service$ sudo rm -rf node_modules/; npm install

ubuntu@ors-pelias-importer:~/pip-service$ npm ls | grep pelias-
pelias-pip-service@0.0.0-development /home/ubuntu/pip-service
├─┬ pelias-logger@0.4.2
│ ├─┬ pelias-config@3.0.2
├─┬ pelias-mock-logger@1.3.0
├─┬ pelias-wof-admin-lookup@4.6.5
│ ├── pelias-config@3.0.2 deduped
│ ├── pelias-logger@0.4.2 deduped
│ ├─┬ pelias-microservice-wrapper@1.4.0
│ │ ├── pelias-logger@0.4.2 deduped
│ ├─┬ pelias-parallel-stream@0.1.0
│ ├─┬ pelias-whosonfirst@2.22.4
│ │ ├─┬ pelias-config@2.14.0
│ │ ├─┬ pelias-dbclient@2.4.0
│ │ │ ├─┬ pelias-config@2.14.0
│ │ │ ├─┬ pelias-logger@0.3.0
│ │ │ │ ├─┬ pelias-config@2.13.0
│ │ ├─┬ pelias-logger@0.3.1
│ │ │ ├── pelias-config@2.14.0 deduped
│ │ ├─┬ pelias-model@5.3.2
│ │ │ ├─┬ pelias-config@2.14.0
│ │ ├── pelias-parallel-stream@0.1.0 deduped

[orangejulius]

Oh I know what it is. Please remove package-lock.json and that will upgrade you. We did fix that recently, and it's not yet in the production branch.

[nilsnolde]

Yes, worked! Thanks @orangejulius!

[orangejulius]

I am sorry you had to go through the same extremely frustrating experience as I did a few weeks ago resulting in me adding that change to stop using package-lock.json everywhere :)

We are going to get better about keeping the "official" release line for Pelias more up to date. It may be that we remove the production branches, or less likely we will merge a lot more frequently.

[nilsnolde]

No worries, Julian.. It's open source, hiccups here and there are expected. And always a lot happier when there's a solution:) You guys do a terrific job on Pelias! Wish I could contribute more, but lacking a few years nodejs..

[orangejulius]

Hah, well ask @trescube he about that. He started with zero Node.js experience and wrote most of the good parts of Pelias. He only completely broke critical infrastructure in production once, which is more than the rest of us can say :P