Missing data for "Caribbean Netherlands"

pelias / placeholder

stand-alone coarse geocoder

https://placeholder.demo.geocode.earth

MIT License

313 stars 35 forks source link

Missing data for "Caribbean Netherlands" #156

Open arvindkartik opened 5 years ago

arvindkartik commented 5 years ago

"id": 136251281,
"name": "Caribbean Netherlands",
"placetype": "dependency",

There is no short name/abbr present in the DB even though the data is present in WhosOnFirst.

missinglink commented 5 years ago

Hi @arvindkartik,

The record 136251281 is available in the latest placeholder build as seen here: https://parser.synergy.io/demo/#eng

You are correct in saying that there is no abbreviation, what were you expecting to see?

rocainunwired commented 5 years ago

Hi @missinglink , When i checked for other dependencies, like

"id": 85632731,
"name": "Bermuda",
"abbr": "BMU",
we do get a 3 digit abbreviation for them.

Caribbean Netherlands consists of three places (Bonaire, Sint Eustatius and Saba) all of which have the same ISO code "BES". So for Caribbean Netherlands maybe we can have a "abbr": "BES". Or we can go by the parent empire (Netherlands) and can make it "NL" or "NLD". Though "BES" is the correct value

missinglink commented 5 years ago

I've opened a PR with the data provider here https://github.com/whosonfirst-data/whosonfirst-data/pull/1498