search

pelias / polygon-lookup

Fast point-in-polygon intersection for large numbers of polygons.
72 stars 17 forks source link

fix crash when geometry is undefined #7

Closed benkaiser closed 8 years ago

benkaiser commented 8 years ago

Sometimes the geometry in some datasets (some extra features without geometrys)

Rather than crashing on this, just omit the record.

orangejulius commented 8 years ago

Nice catch! Bonus points if you write a test for this as well.

benkaiser commented 8 years ago

I know. Was easier to just switch to node archiver like was already mentioned in this thread. It works a treat.

On Tue, Apr 19, 2016, 7:16 AM Julian Simioni notifications@github.com wrote:

Nice catch! Bonus points if you write a test for this as well.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/pelias/polygon-lookup/pull/7#issuecomment-211582954

orangejulius commented 8 years ago

Fixed in #8

benkaiser commented 8 years ago

Oh my, serious apologies for my bizzare message above. Was in reply to a different github issue.

Thanks for adding the test @orangejulius

orangejulius commented 8 years ago

No worries, email is hard :P