pelias / polylines

Pelias import pipeline for polyline (road network) data.
MIT License
17 stars 24 forks source link

there is code somewhere looking for .0sv #217

Closed jeremy-rutman closed 5 years ago

jeremy-rutman commented 5 years ago

There is code somewhere (I haven't figured out where yet) that is looking for the .0sv extension on the polylines file - so you have to use .0sv currently.

jeremyr@bolt88:/data_c/users/jeremy/pelias/docker/projects/planet$ pelias prepare interpolation
ls: cannot access '/data/polylines/*.0sv': No such file or directory
- importing polylines
polyline line not found

This occurs when using the 'polylines' extension on the file, (and in pelias.json )

  "imports": {
    "polyline": {
      "datapath": "/data/interpolation",
      "files": [ "planet.polylines" ]
    }
  }

when I replace .polylines with .0sv then all is well

orangejulius commented 5 years ago
# git grep 0sv
Dockerfile:# add convenience script - used to extract the first available pbf file to 0sv
docker_extract.sh:echo '' > /data/polylines/extract.0sv;
docker_extract.sh:  # convert pbf file to 0sv (polylines) format, appending results to polyline file
docker_extract.sh:  echo "converting ${PBF_FILE} to /data/polylines/extract.0sv";
docker_extract.sh:  pbf streets "${PBF_FILE}" >> /data/polylines/extract.0sv;
docker_extract.sh:ls -lah /data/polylines/extract.0sv;

Looks like it's the docker_extract.sh file. Anyways thanks for this PR, it's good to at least have the docs consistent until we can fix this.

@missinglink and I are discussing making the whole pbf/valhalla thing more explicit which would also allow us to remove docker_extract.sh. It's always been a bit of a hack and dates back to our earliest experiments with docker.

jeremy-rutman commented 5 years ago

that docker_extract.sh seems to just be converting pbf to polylines.0sv - iiuc its something else that is searching for *.0sv although i suppose the git grep should have picked it up

orangejulius commented 5 years ago

Oh, yeah: it's over in https://github.com/pelias/interpolation/blob/master/docker_build.sh#L5

Ultimately, we have some work to do to replace some bash scripts with Javascript so that config values in pelias.json can be used.