search

pelias / polylines

Pelias import pipeline for polyline (road network) data.
MIT License
17 stars 24 forks source link

Update "filesize is over 1GB" warning #259

Closed msschl closed 2 years ago

msschl commented 2 years ago

Make the message for the warning "filesize is over 1GB" more clear that the script will exit and no polylines will be generated.

missinglink commented 2 years ago

Looks good, can you please add 2>&1 at the start so the message goes to STDERR instead of STDOUT

msschl commented 2 years ago

@missinglink Done 👍🏽

missinglink commented 2 years ago

Heya, unfortunately the GitHub Actions are not being run because your PR comes from a fork.

I would like them to run the tests and any other steps we have configured before merging.

I've adjusted the GitHub settings now, can you please push an 'empty commit' to trigger the Actions, the commit message can be anything you like.

https://coderwall.com/p/vkdekq/git-commit-allow-empty

msschl commented 2 years ago

Sry for the long delay. I've added an empty commit

missinglink commented 2 years ago

ugh, didn't work, I've replaced this PR with https://github.com/pelias/polylines/pull/260 and tried to maintain authorship attribution as best I could.