pelias / schema

elasticsearch schema files and tooling
MIT License
40 stars 76 forks source link

Remove peliasQueryFullToken analyzer #407

Closed Joxit closed 4 years ago

Joxit commented 4 years ago

Since we merged our beloved pelias parser, this analyser is no more used :wave:.

missinglink commented 4 years ago

Can we also remove peliasQueryPartialToken and partial_token_address_suffix_expansion along with any synonyms?

missinglink commented 4 years ago

More info on this PR: https://github.com/pelias/schema/pull/370

Joxit commented 4 years ago

Oh yes, I forgot these two :smile: updated and I have not forgotten the integration tests :sweat_smile:

missinglink commented 4 years ago

Ok so since https://github.com/pelias/api/pull/1330 was merged 5 months ago, I think that's enough of a deprecation window, these analyzers are now redundant and removing them cleans up the schema a bunch.

orangejulius commented 4 years ago

Wow -900 lines! :clap:

missinglink commented 4 years ago

Yeah and 140 from the schema file itself!