Closed blackmad closed 4 years ago
The only real negative I can see with this is that it might have a performance penalty at index-time, so it's relatively safe to merge, although I can't see half of these words being used in place names?
Some thoughts:
verbs
and adjectives
which are less common in place names compared with nouns
, eg:"cannibalise,cannibalize",
"cannibalised,cannibalized",
"cannibalises,cannibalizes",
"cannibalising,cannibalizing",
If this is the case then spelling-correction would to some degree solve the same problem.
[edit] actually I had another look at the list and none of my examples in 3. were actually listed!?
I like the idea but I'm not in love with the list generated from this npm
module TBH
I'll try to pare this list down by limiting it to words that are only small edit distances apart + actually appear in OSM
On Wed, Sep 23, 2020 at 8:33 AM Peter Johnson notifications@github.com wrote:
I like the idea but I'm not in love with the list generated from this npm module TBH
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pelias/schema/pull/467#issuecomment-697333782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMZMCPNQG2V6EBZXTVOMLSHHTK5ANCNFSM4RV7V4HA .
-- David Blackman creative technologist & wandering help me find my purpose http://purpose.blackmad.com
Perfect, I agree with Peter that this list is almost certainly far too long. I'd be happier with a list of at most 500 words, and if we cross reference with OSM data then that's even better.
Ready to merge, check up to date first
We need a Conventional Commit commit message as well so that this generates proper releases and changelog notes as well (maybe there is a GitHub Action to test for these, since we're not very good at remembering?)
I've added a feat()
commit message via squash
This was motivated by someone searching for "Marina Theater" when the correct name of the POI is "Marina Theatre" - by adding aliases at index time this should fix such searches in both autocomplete & search.