pelias / schema

elasticsearch schema files and tooling
MIT License
40 stars 76 forks source link

add github actions workflow to replace travis #468

Closed missinglink closed 3 years ago

missinglink commented 4 years ago

Add config from https://github.com/pelias/api/pull/1495 in another repo with a different testing requirement (build matrix, external database).

missinglink commented 3 years ago

This PR had some messy commits, I've cleaned it up now and opened the PR up for review/merging.

missinglink commented 3 years ago

note: at time of writing there is an outage which may affect the checks: https://github.com/pelias/openaddresses/pull/478#issuecomment-768800427

orangejulius commented 3 years ago

This one doesn't remove .travis.yml, is that intentional?

missinglink commented 3 years ago

This one doesn't remove .travis.yml, is that intentional?

Yes/No ⚖️, initially it seemed best to leave both CI systems running, but since we've now lived with Actions a while and not had any issues we might consider removing .travis.yml here and also https://github.com/pelias/api where I left it during the first PR.

missinglink commented 3 years ago

I removed .travis.yml via rebase

missinglink commented 3 years ago

I've set the CI actions to be required before merging a PR, any PRs authored before this was merged will require a rebase.