search

pelias / schema

elasticsearch schema files and tooling
MIT License
40 stars 75 forks source link

CI: Remove Node.js 12 from build matrix #489

Closed orangejulius closed 1 year ago

orangejulius commented 1 year ago

We normally try to keep all our CI configurations identical, but the schema repository is a bit of a special case since it has to do so many extra things around Elasticsearch.

Apparently, one of those extra things, npm install -g npm, now installs a new enough version of NPM that it doesn't work on Node.js 12.

We are removing Node.js 12 support globally soon anyway in https://github.com/pelias/pelias/issues/950, so we might as well remove it here to make all the tests pass again.

orangejulius commented 1 year ago

Actually, I'd like to add npm install -g npm globally to all our CI eventually. It's a good best practice to insure NPM itself is working as well as it can.

We should probably make a ticket to track making this change, as well as a few others, across all our CI configs. As I recall they are all drifting a bit as we explore new things like how to enable unit tests on external pull requests, etc.