search

pelias / schema

elasticsearch schema files and tooling
MIT License
40 stars 76 forks source link

Remove JDK configuration from CI #492

Open orangejulius opened 1 year ago

orangejulius commented 1 year ago

For quite some time we have configured a specific version of the JDK in our CI.

As far as I understand it, modern versions of Elasticsearch use a bundled version of the JDK so this configuration may no longer be relevant.

On a practical/security note: it also looks like the scripts used to switch JDK versions are over 4 years old, and just calling a bash script from a 3rd party repository is a bit scary.

I don't see any changes due to the removal of this option, is it possible we don't need it anymore? @missinglink what do you think?

missinglink commented 1 year ago

Yeah I'm fine to remove this.

The original reason was in order to be able to test different versions of the JDK in a split-test production environment.

I think that can also be achieved through custom Docker files.