Default `whosonfirst.sqlite` to true

pelias / whosonfirst

Importer for Who's on First gazetteer

MIT License

27 stars 42 forks source link

Closed orangejulius closed 4 years ago

orangejulius commented 5 years ago

We have been testing the SQLite download option introduced in https://github.com/pelias/whosonfirst/pull/417 for some time, and it appears to be pretty solid.

As far as I know, the SQLite databases are the preferred distribution method for WOF data going forward.

What is left before we consider setting whosonfirst.sqlite to true by default?

orangejulius commented 5 years ago

There's at least one blocker for this: the wof-admin-lookup tests currently fail when sqlite is set to true: https://github.com/pelias/wof-admin-lookup/issues/262

Joxit commented 5 years ago

Now that pelias/wof-admin-lookup#262 is fixed, I think we can set SQLite by default :smile:.

orangejulius commented 4 years ago

We've done lots of testing with SQLite DBs recently. They are definitely the way of the future and already work well today.

Two PRs left to merge before we can do this:

https://github.com/pelias/placeholder/pull/157 (and https://github.com/pelias/placeholder/pull/169 which improves it) to add SQLite support to Placeholder
477 to avoid downloading both the full planet and country DBs from dist.whosonfirst.org

Should happen soon!